Re: [PATCH v15 00/11] livepatch: Atomic replace feature

From: Josh Poimboeuf
Date: Fri Jan 11 2019 - 12:44:54 EST


On Wed, Jan 09, 2019 at 01:43:18PM +0100, Petr Mladek wrote:
> Changes against v14:
>
> + Rename klp_active -> klp_added [Josh]
>
> + Do not clear klp_added variable in klp_free*() [Josh]
>
> + Rename klp_init_patch_before_free() -> klp_init_patch_early()
> [Josh]
>
> + Do not call klp_free_patch() when
> kobject_init_and_add(&patch->kobj) fails in 3rd patch.
> The final code stays the same after the refactoring
> in 5th patch. [Josh]
>
> + Better 4th patch subject [Josh]
>
> + Use safe iterators in klp_free() functions already in 7th
> patch instead of in 8th [Josh]
>
> + Rename free_all -> nops_only and revert the logic in
> klp_free*() and klp_unpatch_object*() functions [Josh]
>
> + Do not refuse loading conflicting patches. Just remove
> the ordering (stacking) [Josh]
>
> + fixed typos, improved wording [all]

Petr,

This looks great to me. Thanks for all your patience and hard work!

Acked-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>

--
Josh