Re: [PATCH v3 4/4] /proc/stat: Call kstat_irqs_usr() only for active IRQs

From: Thomas Gleixner
Date: Fri Jan 11 2019 - 14:19:41 EST


On Fri, 11 Jan 2019, Thomas Gleixner wrote:
> --- a/kernel/irq/internals.h
> +++ b/kernel/irq/internals.h
> @@ -246,6 +246,7 @@ static inline void kstat_incr_irqs_this_
> {
> __this_cpu_inc(*desc->kstat_irqs);
> __this_cpu_inc(kstat.irqs_sum);
> + desc->tot_count++;

There is one issue here. True percpu interrupts, like the timer interrupts
on ARM(64), will access that in parallel. But that's not rocket science to
fix.

Thanks,

tglx