Re: [PATCH v4 12/14] arm64: dts: qcom: pmi8994: add interrupt controller properties

From: Bjorn Andersson
Date: Mon Jan 14 2019 - 19:43:47 EST


On Sun 13 Jan 07:47 PST 2019, Brian Masney wrote:

> Add interrupt controller properties now that spmi-gpio is a proper
> hierarchical IRQ chip. The interrupts property is no longer needed so
> remove it.
>
> This change was not tested on any hardware but the same change was
> tested on qcom-pm8941.dtsi using a LG Nexus 5 (hammerhead) phone with
> no issues.
>

Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

> Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx>
> ---
> This is a new patch introduced in V4.
>
> arch/arm64/boot/dts/qcom/pmi8994.dtsi | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
> index dae1cdc23f54..3aee10e3f921 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
> @@ -15,16 +15,8 @@
> reg = <0xc000>;
> gpio-controller;
> #gpio-cells = <2>;
> - interrupts = <2 0xc0 0 IRQ_TYPE_NONE>,
> - <2 0xc1 0 IRQ_TYPE_NONE>,
> - <2 0xc2 0 IRQ_TYPE_NONE>,
> - <2 0xc3 0 IRQ_TYPE_NONE>,
> - <2 0xc4 0 IRQ_TYPE_NONE>,
> - <2 0xc5 0 IRQ_TYPE_NONE>,
> - <2 0xc6 0 IRQ_TYPE_NONE>,
> - <2 0xc7 0 IRQ_TYPE_NONE>,
> - <2 0xc8 0 IRQ_TYPE_NONE>,
> - <2 0xc9 0 IRQ_TYPE_NONE>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> };
> };
>
> --
> 2.17.2
>