Re: [PATCH 09/10] drm/mxsfb: Improve the axi clock usage

From: Robert Chiras
Date: Tue Jan 15 2019 - 04:53:18 EST

Next message: Yogesh Narayan Gaur: "RE: [PATCH v6 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller"
Previous message: Yogesh Narayan Gaur: "[PATCH v7 5/5] MAINTAINERS: add maintainers for the NXP FlexSPI driver"
In reply to: Stefan Agner: "Re: [PATCH 09/10] drm/mxsfb: Improve the axi clock usage"
Next in thread: Robert Chiras: "[PATCH 10/10] drm/mxsfb: Clear OUTSTANDING_REQS bits"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mi, 2019-01-09 at 18:09 +0100, Stefan Agner wrote:
> On 09.01.2019 15:13, Robert Chiras wrote:
> >
> > Currently, the enable of the axi clock return status is ignored,
> > causing
> > issues when the enable fails then we try to disable it. Therefore,
> > it is
> > better to check the return status and disable it only when enable
> > succeeded.
> > Also, remove the helper functions around clk_axi, since we can
> > directly
> > use the clk API function for enable/disable the clock. Those
> > functions
> > are already checking for NULL clk and returning 0 if that's the
> > case.
> Can we maybe even use the runtime PM system for that (adding two
> callbacks for SET_RUNTIME_PM_OPS)?
>
> I suggested it a while ago, but did not looked deeper into it:
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flk
> ml.org%2Flkml%2F2018%2F8%2F1%2F300&data=02%7C01%7Crobert.chiras%4
> 0nxp.com%7Cfb15abdd151b4c643f4f08d67655464a%7C686ea1d3bc2b4c6fa92cd99
> c5c301635%7C0%7C0%7C636826505961622511&sdata=MxpNiBXFW6gw9U8rKRF2
> 0ji73tZ5X5GqZWcninDBFWk%3D&reserved=0
>
> Since we basically enable on mxsfb_crtc_enable and disable on
> mxsfb_crtc_disable, I think it would be pretty much the same thing.
>
> --
> Stefan
>

Hi Stefan,

I don't think I fully understand your suggestion here. The axi clock is
used when we are trying to access LCDIF registers while the block is
not running. For example, when the vblank needs to be enabled/disabled
while the block is idle (so it doesn't have anything to do with
mxsfb_crtc_enable/disable). How could the PM callbacks handle this
case?

Thanks,
Robert

>
> >
> >
> > Signed-off-by: Robert Chiras <robert.chiras@xxxxxxx>
> > Acked-by: Leonard Crestez <leonard.crestez@xxxxxxx>
> > ---
> > Âdrivers/gpu/drm/mxsfb/mxsfb_crtc.c |ÂÂ8 ++++----
> > Âdrivers/gpu/drm/mxsfb/mxsfb_drv.cÂÂ| 32 +++++++++++++-------------
> > ------
> > Âdrivers/gpu/drm/mxsfb/mxsfb_drv.hÂÂ|ÂÂ3 ---
> > Â3 files changed, 17 insertions(+), 26 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
> > b/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
> > index 8d1b6a6..b9437c7 100644
> > --- a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
> > +++ b/drivers/gpu/drm/mxsfb/mxsfb_crtc.c
> > @@ -411,7 +411,7 @@ void mxsfb_crtc_enable(struct mxsfb_drm_private
> > *mxsfb)
> > Â{
> > Â dma_addr_t paddr;
> > Â
> > - mxsfb_enable_axi_clk(mxsfb);
> > + clk_prepare_enable(mxsfb->clk_axi);
> > Â writel(0, mxsfb->base + LCDC_CTRL);
> > Â mxsfb_crtc_mode_set_nofb(mxsfb);
> > Â
> > @@ -428,7 +428,7 @@ void mxsfb_crtc_enable(struct mxsfb_drm_private
> > *mxsfb)
> > Âvoid mxsfb_crtc_disable(struct mxsfb_drm_private *mxsfb)
> > Â{
> > Â mxsfb_disable_controller(mxsfb);
> > - mxsfb_disable_axi_clk(mxsfb);
> > + clk_disable_unprepare(mxsfb->clk_axi);
> > Â}
> > Â
> > Âvoid mxsfb_plane_atomic_update(struct mxsfb_drm_private *mxsfb,
> > @@ -456,9 +456,9 @@ void mxsfb_plane_atomic_update(struct
> > mxsfb_drm_private *mxsfb,
> > Â
> > Â paddr = mxsfb_get_fb_paddr(mxsfb);
> > Â if (paddr) {
> > - mxsfb_enable_axi_clk(mxsfb);
> > + clk_prepare_enable(mxsfb->clk_axi);
> > Â writel(paddr, mxsfb->base + mxsfb->devdata-
> > >next_buf);
> > - mxsfb_disable_axi_clk(mxsfb);
> > + clk_disable_unprepare(mxsfb->clk_axi);
> > Â }
> > Â
> > Â if (!fb || !old_fb)
> > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> > b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> > index 135b8e1..5e18353 100644
> > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> > @@ -103,18 +103,6 @@ drm_pipe_to_mxsfb_drm_private(struct
> > drm_simple_display_pipe *pipe)
> > Â return container_of(pipe, struct mxsfb_drm_private, pipe);
> > Â}
> > Â
> > -void mxsfb_enable_axi_clk(struct mxsfb_drm_private *mxsfb)
> > -{
> > - if (mxsfb->clk_axi)
> > - clk_prepare_enable(mxsfb->clk_axi);
> > -}
> > -
> > -void mxsfb_disable_axi_clk(struct mxsfb_drm_private *mxsfb)
> > -{
> > - if (mxsfb->clk_axi)
> > - clk_disable_unprepare(mxsfb->clk_axi);
> > -}
> > -
> > Â/**
> > Â * mxsfb_atomic_helper_check - validate state object
> > Â * @dev: DRM device
> > @@ -237,25 +225,31 @@ static void mxsfb_pipe_update(struct
> > drm_simple_display_pipe *pipe,
> > Âstatic int mxsfb_pipe_enable_vblank(struct drm_simple_display_pipe
> > *pipe)
> > Â{
> > Â struct mxsfb_drm_private *mxsfb =
> > drm_pipe_to_mxsfb_drm_private(pipe);
> > + int ret = 0;
> > +
> > + ret = clk_prepare_enable(mxsfb->clk_axi);
> > + if (ret)
> > + return ret;
> > Â
> > Â /* Clear and enable VBLANK IRQ */
> > - mxsfb_enable_axi_clk(mxsfb);
> > Â writel(CTRL1_CUR_FRAME_DONE_IRQ, mxsfb->base + LCDC_CTRL1
> > + REG_CLR);
> > Â writel(CTRL1_CUR_FRAME_DONE_IRQ_EN, mxsfb->base +
> > LCDC_CTRL1 + REG_SET);
> > - mxsfb_disable_axi_clk(mxsfb);
> > + clk_disable_unprepare(mxsfb->clk_axi);
> > Â
> > - return 0;
> > + return ret;
> > Â}
> > Â
> > Âstatic void mxsfb_pipe_disable_vblank(struct
> > drm_simple_display_pipe *pipe)
> > Â{
> > Â struct mxsfb_drm_private *mxsfb =
> > drm_pipe_to_mxsfb_drm_private(pipe);
> > Â
> > + if (clk_prepare_enable(mxsfb->clk_axi))
> > + return;
> > +
> > Â /* Disable and clear VBLANK IRQ */
> > - mxsfb_enable_axi_clk(mxsfb);
> > Â writel(CTRL1_CUR_FRAME_DONE_IRQ_EN, mxsfb->base +
> > LCDC_CTRL1 + REG_CLR);
> > Â writel(CTRL1_CUR_FRAME_DONE_IRQ, mxsfb->base + LCDC_CTRL1
> > + REG_CLR);
> > - mxsfb_disable_axi_clk(mxsfb);
> > + clk_disable_unprepare(mxsfb->clk_axi);
> > Â}
> > Â
> > Âstatic struct drm_simple_display_pipe_funcs mxsfb_funcs = {
> > @@ -440,7 +434,7 @@ static irqreturn_t mxsfb_irq_handler(int irq,
> > void *data)
> > Â struct mxsfb_drm_private *mxsfb = drm->dev_private;
> > Â u32 reg;
> > Â
> > - mxsfb_enable_axi_clk(mxsfb);
> > + clk_prepare_enable(mxsfb->clk_axi);
> > Â
> > Â reg = readl(mxsfb->base + LCDC_CTRL1);
> > Â
> > @@ -449,7 +443,7 @@ static irqreturn_t mxsfb_irq_handler(int irq,
> > void *data)
> > Â
> > Â writel(CTRL1_CUR_FRAME_DONE_IRQ, mxsfb->base + LCDC_CTRL1
> > + REG_CLR);
> > Â
> > - mxsfb_disable_axi_clk(mxsfb);
> > + clk_disable_unprepare(mxsfb->clk_axi);
> > Â
> > Â return IRQ_HANDLED;
> > Â}
> > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.h
> > b/drivers/gpu/drm/mxsfb/mxsfb_drv.h
> > index c15b4f9..ce98411 100644
> > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.h
> > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.h
> > @@ -47,9 +47,6 @@ struct mxsfb_drm_private {
> > Âint mxsfb_setup_crtc(struct drm_device *dev);
> > Âint mxsfb_create_output(struct drm_device *dev);
> > Â
> > -void mxsfb_enable_axi_clk(struct mxsfb_drm_private *mxsfb);
> > -void mxsfb_disable_axi_clk(struct mxsfb_drm_private *mxsfb);
> > -
> > Âvoid mxsfb_crtc_enable(struct mxsfb_drm_private *mxsfb);
> > Âvoid mxsfb_crtc_disable(struct mxsfb_drm_private *mxsfb);
> > Âvoid mxsfb_plane_atomic_update(struct mxsfb_drm_private *mxsfb,

Next message: Yogesh Narayan Gaur: "RE: [PATCH v6 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller"
Previous message: Yogesh Narayan Gaur: "[PATCH v7 5/5] MAINTAINERS: add maintainers for the NXP FlexSPI driver"
In reply to: Stefan Agner: "Re: [PATCH 09/10] drm/mxsfb: Improve the axi clock usage"
Next in thread: Robert Chiras: "[PATCH 10/10] drm/mxsfb: Clear OUTSTANDING_REQS bits"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]