Re: [PATCH v2 2/5] dt-binding: pcf8523: add xtal load capacitance

From: Rob Herring
Date: Tue Jan 15 2019 - 16:07:03 EST


On Tue, 8 Jan 2019 19:54:11 +0100, Sam Ravnborg wrote:
> The NXP pcf8523 supports two different xtal load capacitance
> - 7000fF (7pF) HW default
> - 12500fF (12.5pF) Minimum power consumption, driver default
>
> To obtain a precise RTC the pcf8523 must be configured
> with the correct capacitance load of the xtal.
>
> Add a property to specify the xtal capacitance load.
> The default value matches that of the current Linux driver.
>
> With a dedicated binding remove the entry in rtc.txt
>
> Signed-off-by: Søren Andersen <san@xxxxxxx>
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> ---
> Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt | 18 ++++++++++++++++++
> Documentation/devicetree/bindings/rtc/rtc.txt | 1 -
> 2 files changed, 18 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt
>

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>