Re: [PATCH net] Revert "rxrpc: Allow failed client calls to be retried"

[David Miller]

From: David Howells <dhowells@xxxxxxxxxx>
Date: Thu, 10 Jan 2019 16:59:13 +0000

> The changes introduced to allow rxrpc calls to be retried creates an issue
> when it comes to refcounting afs_call structs.  The problem is that when
> rxrpc_send_data() queues the last packet for an asynchronous call, the
> following sequence can occur:
 ...
> Synchronising the clean up after rxrpc_kernel_send_data() returns an error
> with the asynchronous cleanup is then tricky to get right.
> 
> Mostly revert commit c038a58ccfd6704d4d7d60ed3d6a0fca13cf13a4.  The two API
> functions the original commit added aren't currently used.  This makes
> rxrpc_kernel_send_data() always return successfully if it queued the data
> it was given.
> 
> Note that this doesn't affect synchronous calls since their Rx notification
> function merely pokes a wait queue and does not refcounting.  The
> asynchronous call notification function *has* to do refcounting and pass a
> ref over the work item to avoid the need to sync the workqueue in call
> cleanup.
> 
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>

Applied.