Re: [PATCH v5 0/7] mfd / platform: cros_ec: move cros_ec sysfs attributes to its own drivers.

From: Lee Jones
Date: Wed Jan 16 2019 - 03:51:31 EST


On Wed, 12 Dec 2018, Enric Balletbo i Serra wrote:

> Hi,
>
> This is another patchset to try to cleanup a bit more the crossed
> references for cros-ec driver between the MFD and the platform/chrome
> subsystems.
>
> The purpose of these patches is get rid of the different cros-ec attributes
> from mfd/cros_ec_dev to its own sub-driver in platform/chrome. cros_ec_dev
> continues instantiating the sub-devices but the sysfs attributes are owned
> by the platform driver.E.g. The lightbar driver should own his sysfs
> attributes and be instantiated only if the Embedded Controller has a
> lightbar.
>
> The patchset also adds the documentation of the sysfs attributes.
>
> Most of the patches touches mfd subsystem and platform/chrome so I'd
> suggest go all using and inmutable branch.
>
> Best regards,
> Enric

[...]

> Enric Balletbo i Serra (7):
> mfd / platform: cros_ec: use devm_mfd_add_devices
> mfd / platform: cros_ec: move lightbar attributes to its own driver
> mfd / platform: cros_ec: move vbc attributes to its own driver
> mfd / platform: cros_ec: move debugfs attributes to its own driver
> mfd / platform: cros_ec: move device sysfs attributes to its own
> driver
> mfd / platform: cros_ec_vbc: instantiate only if the EC has a VBC
> NVRAM
> platform/chrome: cros_ec_lightbar: instantiate only if the EC has a
> lightbar

These patches have been applied to my local MFD tree. It will be
pushed when 5.0-rc3 has been released. The MFD tree needs rebasing
onto it since it contains all of the MFD patches due for v5.0.

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog