[PATCH v4] binderfs: fix error return code in binderfs_fill_super()

From: Wei Yongjun
Date: Wed Jan 16 2019 - 05:37:05 EST


Fix to return a negative error code -ENOMEM from the new_inode() and
d_make_root() error handling cases instead of 0, as done elsewhere in
this function.

Fixes: 849d540ddfcd ("binderfs: implement "max" mount option")
Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
Reviewed-by: Christian Brauner <christian@xxxxxxxxxx>
---
v1 -> v2: move 'ret = -ENOMEM' out of if
v2 -> v3: use correct fixes commit
v3 -> v4: add reviewed-by
---
drivers/android/binderfs.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
index 9518e2e..e4ff4c3 100644
--- a/drivers/android/binderfs.c
+++ b/drivers/android/binderfs.c
@@ -518,6 +518,7 @@ static int binderfs_fill_super(struct super_block *sb, void *data, int silent)

sb->s_fs_info = info;

+ ret = -ENOMEM;
inode = new_inode(sb);
if (!inode)
goto err_without_dentry;