Re: [PATCH] etnaviv: allow to build on ARC

From: Lucas Stach
Date: Wed Jan 16 2019 - 11:25:52 EST


Am Mittwoch, den 16.01.2019, 08:21 -0800 schrieb Christoph Hellwig:
> On Mon, Jan 14, 2019 at 07:31:57PM +0300, Eugeniy Paltsev wrote:
> > ARC HSDK SoC has Vivante GPU IP so allow build etnaviv for ARC.
> >
> > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@xxxxxxxxxxxx>
> > ---
> > Âdrivers/gpu/drm/etnaviv/Kconfig | 2 +-
> > Â1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/etnaviv/Kconfig
> > b/drivers/gpu/drm/etnaviv/Kconfig
> > index 342591a1084e..49a9957c3373 100644
> > --- a/drivers/gpu/drm/etnaviv/Kconfig
> > +++ b/drivers/gpu/drm/etnaviv/Kconfig
> > @@ -2,7 +2,7 @@
> > Âconfig DRM_ETNAVIV
> > Â tristate "ETNAVIV (DRM support for Vivante GPU IP cores)"
> > Â depends on DRM
> > - depends on ARCH_MXC || ARCH_DOVE || ARM || COMPILE_TEST
> > + depends on ARCH_MXC || ARCH_DOVE || ARM || ARC ||
> > COMPILE_TEST
>
> Is there any reason to not just remove the dependencies entirely?
> It seems like it could literally build everywhere, and who knows what
> other SOCs the IP blocks end up in sooner or later?

I've just sent out a patch to do exactly this instead of playing whack-
a-mole with all the architectures. The patch has been chewed on by the
0-day robot since yesterday and didn't turn up any obvious fallout yet.

Regards,
Lucas