Re: ufshcd_queuecommand() triggering after ufshcd_suspend()?
From: John Stultz
Date: Wed Jan 16 2019 - 17:14:26 EST
On Sun, Jan 13, 2019 at 7:25 PM Zang Leigang <zangleigang@xxxxxxxxxxxxx> wrote:
> I think there are two different issues:
> 1. clk_gating's state(including state's trace event) and is_suspended is not
> wrapped by ufshcd_is_clkgating_allowed which Hisilicon's kirin platoform
> soc does not need but is set and checked in a regular path.
> 2. I think SCSI is necessary to block queue to stop sending to ufs after
> system suspend or, add a new state for ufs like UFSHCD_STATE_SUSPENDING
> or what else. hba->is_sys_suspended is too late to stop ufshcd_queuecommand
Thanks for the suggestions. I'm not sure I have enough context to
try to come up with a patch. I'll try to take a stab at it, but I'd
appreciate it if you have any more specific suggestions or patches
for me to try. :)