Re: [PATCH] mm/page_alloc: check return value of memblock_alloc_node_nopanic()

[William Kucharski]

> On Jan 17, 2019, at 4:26 AM, Mike Rapoport <rppt@xxxxxxxxxxxxx> wrote:
> 
> On Thu, Jan 17, 2019 at 03:19:35AM -0700, William Kucharski wrote:
>> 
>> This seems very reasonable, but if the code is just going to panic if the
>> allocation fails, why not call memblock_alloc_node() instead?
> 
> I've sent patches [1] that remove panic() from memblock_alloc*() and drop
> _nopanic variants. After they will be (hopefully) merged,
> memblock_alloc_node() will return NULL on error.
> 
>> If there is a reason we'd prefer to call memblock_alloc_node_nopanic(),
>> I'd like to see pgdat->nodeid printed in the panic message as well.
> 
> Sure.

Thanks for the quick response.

Reviewed-by: William Kucharski <william.kucharski@xxxxxxxxxx>