Re: [PATCH v2] media: imx-csi: Input connections to CSI should be optional

From: Fabio Estevam
Date: Thu Jan 17 2019 - 16:06:42 EST


Hi Steve,

On Thu, Jan 17, 2019 at 6:59 PM Steve Longerbeam <slongerbeam@xxxxxxxxx> wrote:
>
> Some imx platforms do not have fwnode connections to all CSI input
> ports, and should not be treated as an error. This includes the
> imx6q SabreAuto, which has no connections to ipu1_csi1 and ipu2_csi0.
> Return -ENOTCONN in imx_csi_parse_endpoint() so that v4l2-fwnode
> endpoint parsing will not treat an unconnected CSI input port as
> an error.
>
> Fixes: c893500a16baf ("media: imx: csi: Register a subdev notifier")
>
> Signed-off-by: Steve Longerbeam <slongerbeam@xxxxxxxxx>
> Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> Acked-by: Tim Harvey <tharvey@xxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx

Thanks. This fixes the following error messages:

[ 3.449564] imx-ipuv3 2400000.ipu: driver could not parse
port@1/endpoint@0 (-22)
[ 3.457342] imx-ipuv3-csi: probe of imx-ipuv3-csi.1 failed with error -22
[ 3.464498] imx-ipuv3 2800000.ipu: driver could not parse
port@0/endpoint@0 (-22)
[ 3.472120] imx-ipuv3-csi: probe of imx-ipuv3-csi.4 failed with error -22

Tested-by: Fabio Estevam <festevam@xxxxxxxxx>