Re: [PATCH v2 4/4] gcov: clang: pick GCC vs Clang format depending on compiler

From: Nick Desaulniers
Date: Thu Jan 17 2019 - 16:48:59 EST


On Wed, Jan 16, 2019 at 2:19 AM Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
> > I think this was the suggestion from Masahiro from v1?
>
> Yes.
>
>
> What is strange is, 2/4 added GCOV_FORMAT_CLANG,
> then 4/4 deletes it.
>
>
> Probably, changing the patch order,
> or squashing 4/4 into 2/4 would be cleaner.

Sure; Tri, I think it's ok for you to become author of 2/4 and put a
"Co-authored-by:" tag for Greg.

--
Thanks,
~Nick Desaulniers