Re: [PATCH v6 0/5] sched/deadline: fix cpusets bandwidth accounting
From: Juri Lelli
Date: Fri Jan 18 2019 - 11:46:49 EST
On 18/01/19 08:17, Tejun Heo wrote:
> On Thu, Jan 17, 2019 at 09:47:34AM +0100, Juri Lelli wrote:
> > Hi,
> > v6 of a series of patches, originally authored by Mathieu, with the intent
> > of fixing a long standing issue of SCHED_DEADLINE bandwidth accounting.
> > As originally reported by Steve , when hotplug and/or (certain)
> > cpuset reconfiguration operations take place, DEADLINE bandwidth
> > accounting information is lost since root domains are destroyed and
> > recreated.
> > Mathieu's approach is based on restoring bandwidth accounting info on
> > the newly created root domains by iterating through the (DEADLINE) tasks
> > belonging to the configured cpuset(s).
> > Apart from some minor refactoring needed to rebase the set on top of
> > Waiman Long's cpuset for cgroup series (now mainline), two changes worth
> > of notice:
> Generally looks good to me but can you please ask Waiman to take a
Argh! I should have cc-ed him in the first instance.
Thanks for reviewing.
Waiman, do you see anything wrong with this series? Thanks!