Re: [PATCH 12/14] staging: android: ion: Declare helpers for carveout and chunk heaps

[Laura Abbott]

On 1/18/19 1:59 AM, Greg Kroah-Hartman wrote:
> On Fri, Jan 11, 2019 at 12:05:21PM -0600, Andrew F. Davis wrote:
> > When enabled the helpers functions for creating carveout and chunk heaps
> > should have declarations in the ION header.
>
> Why?  No one calls these from what I can tell.
>
> Which makes me believe we should just delete the
> drivers/staging/android/ion/ion_carveout_heap.c and
> drivers/staging/android/ion/ion_chunk_heap.c files as there are no
> in-tree users?
>
> Any objection to me doing that?
>
> thanks,
>
> greg k-h

I'd rather not delete it quite yet. Part of this entire thread is a
discussion on how to let those heaps and associated function actually
be called in some way in tree. I expect them to either get called
in tree or be replaced.

Thanks,
Laura