Re: [PATCH net v2] net: phy: phy driver features are mandatory

From: David Miller
Date: Sat Jan 19 2019 - 13:04:50 EST


From: Camelia Groza <camelia.groza@xxxxxxx>
Date: Thu, 17 Jan 2019 14:22:36 +0200

> Since phy driver features became a link_mode bitmap, phy drivers that
> don't have a list of features configured will cause the kernel to crash
> when probed.
>
> Prevent the phy driver from registering if the features field is missing.
>
> Fixes: 719655a14971 ("net: phy: Replace phy driver features u32 with link_mode bitmap")
> Reported-by: Scott Wood <oss@xxxxxxxxxxxx>
> Signed-off-by: Camelia Groza <camelia.groza@xxxxxxx>
> ---
> v2: Print the name of the driver that has missing features.
>
> This patch should be merged to 4.20 stable.

Applied and queued up for -stable.