Re: [PATCH] arch/sh/mm/consistent.c: Use dma_zalloc_coherent

From: Souptick Joarder
Date: Sun Jan 20 2019 - 08:06:12 EST


On Sun, Oct 28, 2018 at 12:29 PM Sabyasachi Gupta
<sabyasachi.linux@xxxxxxxxx> wrote:
>
> Replaced dma_alloc_coherent + memset with dma_zalloc_coherant
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@xxxxxxxxx>

Acked-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>

> ---
> arch/sh/mm/consistent.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/sh/mm/consistent.c b/arch/sh/mm/consistent.c
> index 792f361..fc8d235 100644
> --- a/arch/sh/mm/consistent.c
> +++ b/arch/sh/mm/consistent.c
> @@ -52,13 +52,12 @@ int __init platform_resource_setup_memory(struct platform_device *pdev,
> if (!memsize)
> return 0;
>
> - buf = dma_alloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
> + buf = dma_zalloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
> if (!buf) {
> pr_warning("%s: unable to allocate memory\n", name);
> return -ENOMEM;
> }
>
> - memset(buf, 0, memsize);
>
> r->flags = IORESOURCE_MEM;
> r->start = dma_handle;
> --
> 2.7.4
>