* Andreas Kemnade <andreas@xxxxxxxxxxxx> [190118 19:39]:
On Fri, 18 Jan 2019 10:36:30 -0800
Tony Lindgren <tony@xxxxxxxxxxx> wrote:
til the next workaround.well, if we want to manually disable it and not automatically,
That flags also causes the iclk being enabled/disabled
Yes but SWSUP_IDLE for the interface clock to me currently
"manually enable and disable ocp interface clock"
we have to disable autoidle or it will be automatically disabled.
Disabling it manually when it is already auto-disabled (by autoidle) is
just practically a no-op towards the clock.
OK I buy that :) It should be probably added to the patch
description to make it clear what it changes.
Tero, any comments on this change?
and with your changes it becomes:Yes, we are, so proper testing is needed. But If I read those comments
"manually enable and disable ocp interface clock and block
autoidle while in use".
So aren't we now changing the way things behave in general
it was always intended this way but not fully implemented because it
appeared to be more work like needing a usecounter (which my patchset
also adds) for that autoidle flag.
OK yeah the use count seems necessary. I'll test here
with my PM use cases.