Re: [PATCH v3 0/8] Add IPROC I2C slave mode and NIC I2C support

From: Ray Jui
Date: Mon Jan 21 2019 - 02:52:44 EST


Hi Rayagonda/Wolfram,

I reviewed the entire patch series and added my Reviewed-by tag on 1/8
and 2/8. The rest of the patches in this series already had my
Signed-off-by tag.

Thanks,

Ray

On 1/17/2019 10:04 PM, Rayagonda Kokatanur wrote:
> Hi,
> This patchset contains support for IPROC I2C slave and NIC I2C support.
> Following are the brief changes done inorder to support both IPROC I2C
> slave mode and NIC I2C,
>
> a. Add support to allow I2C rx transfer upto 255 bytes
> b. Add polling mode support to the iProc I2C driver. Polling mode is used
> in certain SoCs where interrupt is not connected from the I2C block.
> c. Add warpper read/write access for register to support indirect register
> access. This is required in certain SoCs with this iProc I2C
> block registered.
> d. Remove the set RESET bit to LOW right after setting it to HIGH so that
> wait duration can be met.
>
> This patch series is based on kernel v5.0.0-rc2.
>
> Changes from v2:
> - Address Ray's review comments.
>
> Changes from v1:
> - Rebased to Linux v5.0.0-rc2
>
> Ray Jui (1):
> dt-bindings: i2c: iproc: make 'interrupts' optional
>
> Rayagonda Kokatanur (5):
> i2c: iproc: add polling support
> i2c: iproc: use wrapper for read/write access
> dt-bindings: i2c: iproc: add "brcm,iproc-nic-i2c" compatible string
> i2c: iproc: add NIC I2C support
> arm64: dts: Stingray: Add NIC i2c device node
>
> Shreesha Rajashekar (2):
> i2c: iproc: I2C read up to 255 bytes support
> i2c: iproc: Add Slave mode support
>
> .../devicetree/bindings/i2c/brcm,iproc-i2c.txt | 14 +-
> .../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 18 +
> drivers/i2c/busses/Kconfig | 1 +
> drivers/i2c/busses/i2c-bcm-iproc.c | 757 +++++++++++++++++----
> 4 files changed, 659 insertions(+), 131 deletions(-)
>