Re: [PATCH v2] driver core: move device->knode_class to device_private
From: Wei Yang
Date: Mon Jan 21 2019 - 02:58:57 EST
On Fri, Jan 18, 2019 at 04:55:41PM +0100, Greg KH wrote:
>On Fri, Jan 18, 2019 at 10:34:59AM +0800, Wei Yang wrote:
>> As the description of struct device_private says, it stores data which
>> is private to driver core. And it already has similar fields like:
>> knode_parent, knode_driver, knode_driver and knode_bus. This look it is
>> more proper to put knode_class together with those fields to make it
>> private to driver core.
>> This patch move device->knode_class to device_private to make it comply
>> with code convention.
>> Signed-off-by: Wei Yang <richardw.yang@xxxxxxxxxxxxxxx>
>> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>Thanks for this. There are a number of other variables that should move
>into this structure, if you want to take a look into doing that.
Really? I may not notice that yet.
I may try to take a look into this, but not sure I would have enough time :-)
Help you, Help me