Re: [PATCH v1] : Switch to use new generic UUID API

From: Christoph Hellwig
Date: Mon Jan 21 2019 - 03:47:37 EST


On Thu, Jan 10, 2019 at 04:30:51PM +0200, Andy Shevchenko wrote:
> There are new types and helpers that are supposed to be used in new code.
>
> As a preparation to get rid of legacy types and API functions do
> the conversion here.

This seems to miss a "lightnvm" in the subject line.

> static inline void pblk_setup_uuid(struct pblk *pblk)
> {
> + guid_gen((guid_t *)&pblk->instance_uuid);
> }

I think we can just kill this wrapper.

But more importantly the instance_uuid fied, and the header.uuid one
it is copied from should be turned into an actual guid_t, the memcpys
and memcmps should also be replaced with the proper UUID API.