Re: [PATCH v15 5/6] x86/boot: Parse SRAT address from RSDP and store immovable memory

[Chao Fan]

On Mon, Jan 21, 2019 at 10:45:24AM +0100, Borislav Petkov wrote:
>On Mon, Jan 21, 2019 at 05:42:14PM +0800, Chao Fan wrote:
>> Or I clear this function as:
>> static acpi_physical_address get_rsdp_addr(void)
>> {
>>         acpi_physical_address pa;
>> 
>>         pa = get_acpi_rsdp();
>> 
>>         if (!pa)
>>                 pa = boot_params->acpi_rsdp_addr;
>> 
>>         if (!pa)
>>                 pa = efi_get_rsdp_addr();
>> 
>>         if (!pa)
>>                 pa = bios_get_rsdp_addr();
>> 
>>         if (pa && !boot_params->acpi_rsdp_addr)
>>                 boot_params->acpi_rsdp_addr = pa;
>
>Or simply:
>
>	if (pa)
>		boot_params->acpi_rsdp_addr = pa;
>

Make sense. If pa is not zero, boot_params->acpi_rsdp_addr is zero or
the same as pa, so will change it.

Thanks,
Chao Fan

>-- 
>Regards/Gruss,
>    Boris.
>
>Good mailing practices for 400: avoid top-posting and trim the reply.
>
>