Re: [PATCH v4 8/9] phy: Add Cadence D-PHY support

[Maxime Ripard]

Hi Sean,

On Thu, Jan 17, 2019 at 08:53:22AM -0500, Sean Paul wrote:
> On Wed, Jan 09, 2019 at 10:33:25AM +0100, Maxime Ripard wrote:
> > +	opts->wakeup = cdns_dphy_get_wakeup_time_ns(dphy) * 1000;
> 
> This should be "/ 1000" since the units of wakeup is us now (thanks to patch 2).
> You've made this change in patch 9, so I think it's just a misplaced fixup.

Good catch, this was fixed in patch 9, but it definitely belongs there.

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature