Re: [PATCH 5/8] infiniband: mlx5: no need to check return value of debugfs_create functions

From: Leon Romanovsky
Date: Tue Jan 22 2019 - 12:43:03 EST


On Tue, Jan 22, 2019 at 04:17:57PM +0100, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Leon Romanovsky <leon@xxxxxxxxxx>
> Cc: Doug Ledford <dledford@xxxxxxxxxx>
> Cc: Jason Gunthorpe <jgg@xxxxxxxx>
> Cc: linux-rdma@xxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/infiniband/hw/mlx5/cong.c | 15 +++-----
> drivers/infiniband/hw/mlx5/main.c | 8 ++---
> drivers/infiniband/hw/mlx5/mlx5_ib.h | 8 +----
> drivers/infiniband/hw/mlx5/mr.c | 51 +++++-----------------------
> 4 files changed, 18 insertions(+), 64 deletions(-)
>

Thanks,
Acked-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature