Re: [PATCH] brcm80211: no need to check return value of debugfs_create functions

[Greg Kroah-Hartman]

On Tue, Jan 22, 2019 at 09:07:48PM +0100, Arend Van Spriel wrote:
> The prefix should be 'brcmsmac'.
> 
> On 1/22/2019 4:21 PM, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value.  The function can work or not, but the code logic should
> > never do something different based on this.
> 
> I could argue that if above is true it would be better to make the debugfs
> function return void, but I won't ;-p

I would really want to do that, but sometimes you need that return value
to pass to other debugfs functions :(

> In start_creating() the parent dentry is indeed checked for IS_ERR() so...
> 
> Acked-by: Arend van Spriel

thanks for the review!

greg k-h