Re: [PATCH] x86/insn-eval: Mark expected switch fall-through
From: Borislav Petkov
Date: Sat Jan 26 2019 - 04:48:03 EST
On Fri, Jan 25, 2019 at 02:55:20PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
> This patch fixes the following warning:
> arch/x86/lib/insn-eval.c: In function âresolve_default_segâ:
> arch/x86/lib/insn-eval.c:179:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (insn->addr_bytes == 2)
> arch/x86/lib/insn-eval.c:182:2: note: here
> case -EDOM:
> Warning level 3 was used: -Wimplicit-fallthrough=3
> This patch is part of the ongoing efforts to enabling
For the future:
Avoid having "This patch" or "This commit" in the commit message. It is
$ git grep 'This patch' Documentation/process
for more details.
Good mailing practices for 400: avoid top-posting and trim the reply.