Re: [PATCH 5/5] virtio-blk: Consider virtio_max_dma_size() for maximum segment size

From: Christoph Hellwig
Date: Mon Jan 28 2019 - 03:05:31 EST


On Thu, Jan 24, 2019 at 10:51:51AM +0100, Joerg Roedel wrote:
> On Thu, Jan 24, 2019 at 09:42:21AM +0100, Christoph Hellwig wrote:
> > Yes. But more importantly it would fix the limit for all other block
> > drivers that set large segment sizes when running over swiotlb.
>
> True, so it would be something like the diff below? I havn't worked on
> the block layer, so I don't know if that needs additional checks for
> ->dev or anything.

Looks sensible. Maybe for now we'll just do the virtio-blk case
that triggered it, and we'll do something like this patch for the
next merge window. We'll also need to apply the same magic to the
DMA boundary.