Re: [PATCH AUTOSEL 4.19 034/258] sctp: Fix SKB list traversal in sctp_intl_store_reasm().

From: Marcelo Ricardo Leitner
Date: Mon Jan 28 2019 - 12:04:47 EST


On Mon, Jan 28, 2019 at 10:55:40AM -0500, Sasha Levin wrote:
> From: "David S. Miller" <davem@xxxxxxxxxxxxx>
>
> [ Upstream commit 348bbc25c40844c5efa083a3842c7f53d70a815e ]
>
> To be fully correct, an iterator has an undefined value when something
> like skb_queue_walk() naturally terminates.
>
> This will actually matter when SKB queues are converted over to
> list_head.
>
> Formalize what this code ends up doing with the current
> implementation.

I don't think this patch is really needed for -stable without the SKB
queue convertion, but okay.

Marcelo