Re: [PATCH v2 01/12] platform/chrome: cromeos_pstore: switch to SPDX identifier

From: Guenter Roeck
Date: Mon Jan 28 2019 - 14:28:17 EST


On Sat, Jan 26, 2019 at 1:51 AM Enric Balletbo i Serra
<enric.balletbo@xxxxxxxxxxxxx> wrote:
>
> Adopt the SPDX license identifier headers to ease license compliance
> management. Also fix the module license mismatch and change the term
> 'Chrome OS' for 'ChromeOS' to be coherent with other drivers.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>

Reviewed-by: Guenter Roeck <groeck@xxxxxxxxxxxx>

> ---
>
> Changes in v2:
> - Removed the patches that removed the unnused includes (were wrong).
> - Add patches for all files in platform/chrome that didn't switch yet.
>
> drivers/platform/chrome/chromeos_pstore.c | 17 ++++++-----------
> 1 file changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/platform/chrome/chromeos_pstore.c b/drivers/platform/chrome/chromeos_pstore.c
> index b0693fdec8c6..d13770785fb5 100644
> --- a/drivers/platform/chrome/chromeos_pstore.c
> +++ b/drivers/platform/chrome/chromeos_pstore.c
> @@ -1,12 +1,7 @@
> -/*
> - * chromeos_pstore.c - Driver to instantiate Chromebook ramoops device
> - *
> - * Copyright (C) 2013 Google, Inc.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation, version 2 of the License.
> - */
> +// SPDX-License-Identifier: GPL-2.0
> +// Driver to instantiate Chromebook ramoops device.
> +//
> +// Copyright (C) 2013 Google, Inc.
>
> #include <linux/acpi.h>
> #include <linux/dmi.h>
> @@ -138,5 +133,5 @@ static void __exit chromeos_pstore_exit(void)
> module_init(chromeos_pstore_init);
> module_exit(chromeos_pstore_exit);
>
> -MODULE_DESCRIPTION("Chrome OS pstore module");
> -MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("ChromeOS pstore module");
> +MODULE_LICENSE("GPL v2");
> --
> 2.20.1
>