Re: [PATCH v3 6/7] arm64: dts: xilinx: ultra96: Standardize LED labels and triggers
From: Michal Simek
Date: Tue Jan 29 2019 - 08:17:53 EST
On 24. 01. 19 17:49, Rob Herring wrote:
> On Fri, Dec 21, 2018 at 12:51 AM Michal Simek <michal.simek@xxxxxxxxxx> wrote:
>> On 21. 12. 18 3:37, Manivannan Sadhasivam wrote:
>>> On Mon, Oct 29, 2018 at 03:12:44PM +0530, Manivannan Sadhasivam wrote:
>>>> For all 96Boards, the following standard is used for onboard LEDs.
>>>> green:user1 default-trigger: heartbeat
>>>> green:user2 default-trigger: mmc0/disk-activity(onboard-storage)
>>>> green:user3 default-trigger: mmc1 (SD-card)
>>>> green:user4 default-trigger: none, panic-indicator
>>>> yellow:wlan default-trigger: phy0tx
>>>> blue:bt default-trigger: hci0-power
>>>> So lets adopt the same for Ultra96, which is one of the 96Boards
>>>> CE and AI platform. Since the WLAN and BT LEDs are hardwired onboard,
>>>> consolidate only User LEDs.
>>> Any update on this patch?
>> I am still waiting for reaction from Rob.
>> We are keep trying to keep backward compatibility and this patch is
>> breaking it that's why I want to know DT guys reaction on this change.
> dts changes and backwards compatibility are ultimately up to the
> platform maintainers. Your users can yell at you if they care. I only
> ask that changes that break compatibility are documented as doing so.
> Personally, I'm in favor of this change. I'd rather seem uniformity
> across boards and this is just a dev board and LED functions won't
> affect booting.
Then please fix the patch and do it in a way
label = "green:user1"; /* ds2 */
ds2 reflects name on schematics.
in ds4 case default trigger is changes to mmc1. It suggests sd/emmc but
on ultra96 it is sd slot and wifi on second slot.
ds5 - linux,default-trigger = "none"; looks weird. None trigger should
be simply ensured by removing that line.