Re: [PATCH v2 2/2] reset: meson: add g12a compatible string

From: Kevin Hilman
Date: Tue Jan 29 2019 - 10:12:15 EST


Jerome Brunet <jbrunet@xxxxxxxxxxxx> writes:

> Add a compatible for the new g12a SoC family.
>
> Tested-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
> ---
> drivers/reset/reset-meson.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c
> index 5242e0679df7..a8f6549b3af4 100644
> --- a/drivers/reset/reset-meson.c
> +++ b/drivers/reset/reset-meson.c
> @@ -134,6 +134,7 @@ static const struct of_device_id meson_reset_dt_ids[] = {
> { .compatible = "amlogic,meson8b-reset" },
> { .compatible = "amlogic,meson-gxbb-reset" },
> { .compatible = "amlogic,meson-axg-reset" },
> + { .compatible = "amlogic,meson-g12a-reset" },
> { /* sentinel */ },

Looks like this new compatiable isn't used for anything new in the
driver. Let's not add a new compatible unless it's needed fo rnew
behavior.

Kevin