Re: [PATCH] mm,memory_hotplug: Fix scan_movable_pages for gigantic hugepages
From: Oscar Salvador
Date: Wed Jan 30 2019 - 02:52:08 EST
On Tue, Jan 29, 2019 at 11:03:56AM +0100, David Hildenbrand wrote:
> Not sure if encoding the -1 in the previous line is even better now that
> we have more space
> skip = (1 << compound_order(head)) - (page - head + 1);
> Looks good to me.
> > }
I would rather not do that.
For me looks a bit "subtle" why do we add up 1 after substracting page - head.
I think that doing "skip - 1" looks more clear, but I do not have a strong