Re: [PATCH] ipconfig: make the wait for carrier timeout configurable

From: David Miller
Date: Thu Jan 31 2019 - 00:37:30 EST


From: Martin Kepplinger <martink@xxxxxxxxx>
Date: Mon, 28 Jan 2019 12:30:05 +0100

> From: Manfred Schlaegl <manfred.schlaegl@xxxxxxxxxxxxx>
>
> commit 3fb72f1e6e61 ("ipconfig wait for carrier") added a
> "wait for carrier" policy, with a fixed worst case maximum wait
> of two minutes.
>
> This makes the wait for carrier timeout configurable (0 - 240 seconds).
>
> The informative timeout messages introduced with
> commit 5e404cd65860 ("ipconfig: add informative timeout messages while
> waiting for carrier") were adapted. Message output is done in a fixed
> interval of 20 seconds, just like before (240/12).
>
> Signed-off-by: Manfred Schlaegl <manfred.schlaegl@xxxxxxxxxxxxx>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@xxxxxxxxxxxxx>

I would prefer that this be implemented using a kernel command line
parameter.

That way you don't need to rebuild the kernel to adjust the value.

Thanks.