Re: [PATCHv6 6/6] coresight: debug: Add Unique Component Identifier (UCI) table

[Sai Prakash Ranjan]

On 1/31/2019 11:31 PM, Suzuki K Poulose wrote:
> On 31/01/2019 14:22, Sai Prakash Ranjan wrote:
> > Add UCI table for coresight CPU debug module. This patch adds
> > the UCI entries for Kryo CPUs found on MSM8996 which shares
> > the same PIDs as ETMs.
> >
> > Without this, below error is observed on MSM8996:
>
> nit: Subject doesn't match the patch contents. You could simply say :
>
> coresight: cpu-debug: Add support for Qualcomm Kryo

Done.

> > diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c 
> > b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> > index e8819d750938..915d86a39cee 100644
> > --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
> > +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> > @@ -655,24 +655,23 @@ static int debug_remove(struct amba_device *adev)
> > ÂÂÂÂÂ return 0;
> > Â }
> > +static struct amba_cs_uci_id uci_id_debug[] = {
>
> As Stephen mentioned, this must be "const".
>
> Rest looks fine.

Done.

Thanks,
Sai

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation