Re: [PATCH v1] mfd: intel-lpss: Move linux/pm.h to the local header

[Andy Shevchenko]

On Fri, Feb 1, 2019 at 11:50 AM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> On Thu, 24 Jan 2019, Andy Shevchenko wrote:
>
> > We now using a common macro for PM operations in Intel LPSS driver,
> > and, since that macro relies on the definition and macro from linux/pm.h
> > header file, it's logical to include it directly in intel-lpss.h.
> > Otherwise it's a bit fragile and requires a proper ordering
> > of header inclusion in C files.
>
> I don't agree with this.  File which use various headers should
> explicitly include them.  Inheriting header files is non-optimal.
>

intel-lpss.h _is_ using pm.h.
I don't see a contradiction here.

> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> >  drivers/mfd/intel-lpss-acpi.c | 1 -
> >  drivers/mfd/intel-lpss-pci.c  | 1 -
> >  drivers/mfd/intel-lpss.h      | 2 ++
> >  3 files changed, 2 insertions(+), 2 deletions(-)
>
> --
> Lee Jones [æçæ]
> Linaro Services Technical Lead
> Linaro.org â Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog



-- 
With Best Regards,
Andy Shevchenko