Re: [PATCH v4 1/3] PCI: dwc: allow to limit registers set length
From: Lorenzo Pieralisi
Date: Fri Feb 01 2019 - 12:13:57 EST
On Thu, Jan 31, 2019 at 10:08:11AM +0100, Stefan Agner wrote:
> On 30.01.2019 18:54, Lorenzo Pieralisi wrote:
> > On Tue, Dec 04, 2018 at 05:55:26PM +0100, Stefan Agner wrote:
> >> Add length to the struct dw_pcie and check that the accessors
> >> dw_pcie_(rd|wr)_conf() do not read/write beyond that point.
> >> Suggested-by: Trent Piepho <tpiepho@xxxxxxxxxx>
> >> Signed-off-by: Stefan Agner <stefan@xxxxxxxx>
> >> ---
> >> Changes in v4:
> >> - Move length check to dw_pcie_rd_conf
> >> .../pci/controller/dwc/pcie-designware-host.c | 16 ++++++++++++++--
> >> drivers/pci/controller/dwc/pcie-designware.h | 1 +
> >> 2 files changed, 15 insertions(+), 2 deletions(-)
> > Hi Stefan,
> > I wanted to ask you if this series should be considered for v5.1
> > inclusion, it is in the PCI backlog. If it is, let me have a look
> > and if it is OK to go I will likely ask you to rebase it.
> Yes please. With this last change I did not see any regression anymore
> so far.
> Andrey Smirnov picked up the second patch: "PCI: imx6: introduce
> drvdata". Not sure what the plan is with his patchset, if it gets merged
> into v5.1 too then I probably better drop this patch and rebase ontop of
> his series.
Ok, I will get back to you when I merged Andrey's series so that you
can rebase on top of my pci/dwc branch with Andrey's patches applied.