Re: [PATCH v3 09/11] leds: max77650: add LEDs support

[Dan Murphy]

Hi

On 2/1/19 1:45 PM, Jacek Anaszewski wrote:
> Hi Bartosz,
> 
> Thanks for the update.
> 
> On 2/1/19 10:47 AM, Bartosz Golaszewski wrote:
>> From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>>
>> This adds basic support for LEDs for the max77650 PMIC. The device has
>> three current sinks for driving LEDs.
>>
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>> ---
>> Â drivers/leds/KconfigÂÂÂÂÂÂÂÂ |ÂÂ 6 ++
>> Â drivers/leds/MakefileÂÂÂÂÂÂÂ |ÂÂ 1 +
>> Â drivers/leds/leds-max77650.c | 147 +++++++++++++++++++++++++++++++++++
>> Â 3 files changed, 154 insertions(+)
>> Â create mode 100644 drivers/leds/leds-max77650.c
>>
>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
>> index a72f97fca57b..6e7a8f51eccc 100644
>> --- a/drivers/leds/Kconfig
>> +++ b/drivers/leds/Kconfig
>> @@ -608,6 +608,12 @@ config LEDS_TLC591XX
>> ÂÂÂÂÂÂÂ This option enables support for Texas Instruments TLC59108
>> ÂÂÂÂÂÂÂ and TLC59116 LED controllers.
>> Â +config LEDS_MAX77650
>> +ÂÂÂ tristate "LED support for Maxim MAX77650 PMIC"
>> +ÂÂÂ depends on MFD_MAX77650
>> +ÂÂÂ help
>> +ÂÂÂÂÂ LEDs driver for MAX77650 family of PMICs from Maxim Integrated."
>> +
>> Â config LEDS_MAX77693
>> ÂÂÂÂÂ tristate "LED support for MAX77693 Flash"
>> ÂÂÂÂÂ depends on LEDS_CLASS_FLASH
>> diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
>> index 4c1b0054f379..f48b2404dbb7 100644
>> --- a/drivers/leds/Makefile
>> +++ b/drivers/leds/Makefile
>> @@ -61,6 +61,7 @@ obj-$(CONFIG_LEDS_MC13783)ÂÂÂÂÂÂÂ += leds-mc13783.o
>> Â obj-$(CONFIG_LEDS_NS2)ÂÂÂÂÂÂÂÂÂÂÂ += leds-ns2.o
>> Â obj-$(CONFIG_LEDS_NETXBIG)ÂÂÂÂÂÂÂ += leds-netxbig.o
>> Â obj-$(CONFIG_LEDS_ASIC3)ÂÂÂÂÂÂÂ += leds-asic3.o
>> +obj-$(CONFIG_LEDS_MAX77650)ÂÂÂÂÂÂÂ += leds-max77650.o
>> Â obj-$(CONFIG_LEDS_MAX77693)ÂÂÂÂÂÂÂ += leds-max77693.o
>> Â obj-$(CONFIG_LEDS_MAX8997)ÂÂÂÂÂÂÂ += leds-max8997.o
>> Â obj-$(CONFIG_LEDS_LM355x)ÂÂÂÂÂÂÂ += leds-lm355x.o
>> diff --git a/drivers/leds/leds-max77650.c b/drivers/leds/leds-max77650.c
>> new file mode 100644
>> index 000000000000..6b74ce9cac12
>> --- /dev/null
>> +++ b/drivers/leds/leds-max77650.c
>> @@ -0,0 +1,147 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +//
>> +// Copyright (C) 2018 BayLibre SAS
>> +// Author: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>> +//
>> +// LED driver for MAXIM 77650/77651 charger/power-supply.
>> +
>> +#include <linux/i2c.h>
>> +#include <linux/leds.h>
>> +#include <linux/mfd/max77650.h>
>> +#include <linux/module.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/regmap.h>
>> +
>> +#define MAX77650_LED_NUM_LEDSÂÂÂÂÂÂÂ 3
>> +
>> +#define MAX77650_LED_A_BASEÂÂÂÂÂÂÂ 0x40
>> +#define MAX77650_LED_B_BASEÂÂÂÂÂÂÂ 0x43
>> +
>> +#define MAX77650_LED_BR_MASKÂÂÂÂÂÂÂ GENMASK(4, 0)
>> +#define MAX77650_LED_EN_MASKÂÂÂÂÂÂÂ GENMASK(7, 6)
>> +
>> +#define MAX77650_LED_MAX_BRIGHTNESSÂÂÂ MAX77650_LED_BR_MASK
>> +
>> +/* Enable EN_LED_MSTR. */
>> +#define MAX77650_LED_TOP_DEFAULTÂÂÂ BIT(0)
>> +
>> +#define MAX77650_LED_ENABLEÂÂÂÂÂÂÂ GENMASK(7, 6)
>> +#define MAX77650_LED_DISABLEÂÂÂÂÂÂÂ 0x00
>> +
>> +#define MAX77650_LED_A_DEFAULTÂÂÂÂÂÂÂ MAX77650_LED_DISABLE
>> +/* 100% on duty */
>> +#define MAX77650_LED_B_DEFAULTÂÂÂÂÂÂÂ GENMASK(3, 0)
>> +
>> +struct max77650_led {
>> +ÂÂÂ struct led_classdev cdev;
>> +ÂÂÂ struct regmap *map;
>> +ÂÂÂ unsigned int regA;
>> +ÂÂÂ unsigned int regB;

Please don't use camel case.

>> +};
>> +
>> +static struct max77650_led *max77650_to_led(struct led_classdev *cdev)
>> +{
>> +ÂÂÂ return container_of(cdev, struct max77650_led, cdev);
>> +}
>> +
>> +static int max77650_led_brightness_set(struct led_classdev *cdev,
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ enum led_brightness brightness)
>> +{
>> +ÂÂÂ struct max77650_led *led = max77650_to_led(cdev);
>> +ÂÂÂ int val, mask;
>> +

The register value and bits are only 8 bit why an int?

>> +ÂÂÂ mask = MAX77650_LED_BR_MASK | MAX77650_LED_EN_MASK;
>> +
>> +ÂÂÂ if (brightness == LED_OFF)
>> +ÂÂÂÂÂÂÂ val = MAX77650_LED_DISABLE;
>> +ÂÂÂ else
>> +ÂÂÂÂÂÂÂ val = MAX77650_LED_ENABLE | brightness;
>> +
>> +ÂÂÂ return regmap_update_bits(led->map, led->regA, mask, val);
>> +}
>> +
>> +static int max77650_led_probe(struct platform_device *pdev)
>> +{
>> +ÂÂÂ struct device_node *of_node, *child;
>> +ÂÂÂ struct max77650_led *leds, *led;
>> +ÂÂÂ struct device *parent;
>> +ÂÂÂ struct device *dev;
>> +ÂÂÂ struct regmap *map;
>> +ÂÂÂ const char *label;
>> +ÂÂÂ int rv, num_leds;
>> +ÂÂÂ u32 reg;
>> +
>> +ÂÂÂ dev = &pdev->dev;
>> +ÂÂÂ parent = dev->parent;
>> +ÂÂÂ of_node = dev->of_node;
>> +
>> +ÂÂÂ if (!of_node)
>> +ÂÂÂÂÂÂÂ return -ENODEV;
>> +
>> +ÂÂÂ leds = devm_kcalloc(dev, sizeof(*leds),
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ MAX77650_LED_NUM_LEDS, GFP_KERNEL);
>> +ÂÂÂ if (!leds)
>> +ÂÂÂÂÂÂÂ return -ENOMEM;
>> +
>> +ÂÂÂ map = dev_get_regmap(dev->parent, NULL);
>> +ÂÂÂ if (!map)
>> +ÂÂÂÂÂÂÂ return -ENODEV;
>> +
>> +ÂÂÂ num_leds = of_get_child_count(of_node);
>> +ÂÂÂ if (!num_leds || num_leds > MAX77650_LED_NUM_LEDS)
>> +ÂÂÂÂÂÂÂ return -ENODEV;
>> +
>> +ÂÂÂ for_each_child_of_node(of_node, child) {
>> +ÂÂÂÂÂÂÂ rv = of_property_read_u32(child, "reg", &reg);

Can we use the fwnode_property_read_u32 call here?
And the same for all below as well?


>> +ÂÂÂÂÂÂÂ if (rv || reg >= MAX77650_LED_NUM_LEDS)
>> +ÂÂÂÂÂÂÂÂÂÂÂ return -EINVAL;
>> +
>> +ÂÂÂÂÂÂÂ led = &leds[reg];
>> +ÂÂÂÂÂÂÂ led->map = map;
>> +ÂÂÂÂÂÂÂ led->regA = MAX77650_LED_A_BASE + reg;
>> +ÂÂÂÂÂÂÂ led->regB = MAX77650_LED_B_BASE + reg;
>> +ÂÂÂÂÂÂÂ led->cdev.brightness_set_blocking = max77650_led_brightness_set;
>> +ÂÂÂÂÂÂÂ led->cdev.max_brightness = MAX77650_LED_MAX_BRIGHTNESS;
>> +
>> +ÂÂÂÂÂÂÂ label = of_get_property(child, "label", NULL);
>> +ÂÂÂÂÂÂÂ if (!label) {
>> +ÂÂÂÂÂÂÂÂÂÂÂ led->cdev.name = "max77650::";
>> +ÂÂÂÂÂÂÂ } else {
>> +ÂÂÂÂÂÂÂÂÂÂÂ led->cdev.name = devm_kasprintf(dev, GFP_KERNEL,
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ "max77650:%s", label);
>> +ÂÂÂÂÂÂÂÂÂÂÂ if (!led->cdev.name)
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ return -ENOMEM;
>> +ÂÂÂÂÂÂÂ }
>> +
>> +ÂÂÂÂÂÂÂ of_property_read_string(child, "linux,default-trigger",
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ &led->cdev.default_trigger);
>> +
>> +ÂÂÂÂÂÂÂ rv = devm_of_led_classdev_register(dev, child, &led->cdev);
>> +ÂÂÂÂÂÂÂ if (rv)
>> +ÂÂÂÂÂÂÂÂÂÂÂ return rv;
>> +
>> +ÂÂÂÂÂÂÂ rv = regmap_write(map, led->regA, MAX77650_LED_A_DEFAULT);
>> +ÂÂÂÂÂÂÂ if (rv)
>> +ÂÂÂÂÂÂÂÂÂÂÂ return rv;
>> +
>> +ÂÂÂÂÂÂÂ rv = regmap_write(map, led->regB, MAX77650_LED_B_DEFAULT);
>> +ÂÂÂÂÂÂÂ if (rv)
>> +ÂÂÂÂÂÂÂÂÂÂÂ return rv;
>> +ÂÂÂ }
>> +
>> +ÂÂÂ return regmap_write(map,
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ MAX77650_REG_CNFG_LED_TOP,
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ MAX77650_LED_TOP_DEFAULT);
>> +}
>> +
>> +static struct platform_driver max77650_led_driver = {
>> +ÂÂÂ .driver = {
>> +ÂÂÂÂÂÂÂ .name = "max77650-led",
>> +ÂÂÂ },
>> +ÂÂÂ .probe = max77650_led_probe,
>> +};
>> +module_platform_driver(max77650_led_driver);
>> +
>> +MODULE_DESCRIPTION("MAXIM 77650/77651 LED driver");
>> +MODULE_AUTHOR("Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>");
>> +MODULE_LICENSE("GPL v2");
>>
> 
> Acked-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>
> 


-- 
------------------
Dan Murphy