Re: [PATCH] huegtlbfs: fix page leak during migration of file pages

[Mike Kravetz]

On 1/31/19 6:12 AM, Sasha Levin wrote:
> Hi,
> 
> [This is an automated email]
> 
> This commit has been processed because it contains a "Fixes:" tag,
> fixing commit: 290408d4a250 hugetlb: hugepage migration core.
> 
> The bot has tested the following trees: v4.20.5, v4.19.18, v4.14.96, v4.9.153, v4.4.172, v3.18.133.
> 
> v4.20.5: Build OK!
> v4.19.18: Build OK!
> v4.14.96: Build OK!
> v4.9.153: Failed to apply! Possible dependencies:
>     2916ecc0f9d4 ("mm/migrate: new migrate mode MIGRATE_SYNC_NO_COPY")
> 
> v4.4.172: Failed to apply! Possible dependencies:
>     09cbfeaf1a5a ("mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros")
>     0e749e54244e ("dax: increase granularity of dax_clear_blocks() operations")
>     2916ecc0f9d4 ("mm/migrate: new migrate mode MIGRATE_SYNC_NO_COPY")
>     2a28900be206 ("udf: Export superblock magic to userspace")
>     4420cfd3f51c ("staging: lustre: format properly all comment blocks for LNet core")
>     48b4800a1c6a ("zsmalloc: page migration support")
>     5057dcd0f1aa ("virtio_balloon: export 'available' memory to balloon statistics")
>     52db400fcd50 ("pmem, dax: clean up clear_pmem()")
>     5b7a487cf32d ("f2fs: add customized migrate_page callback")
>     5fd88337d209 ("staging: lustre: fix all conditional comparison to zero in LNet layer")
>     a188222b6ed2 ("net: Rename NETIF_F_ALL_CSUM to NETIF_F_CSUM_MASK")
>     b1123ea6d3b3 ("mm: balloon: use general non-lru movable page feature")
>     b2e0d1625e19 ("dax: fix lifetime of in-kernel dax mappings with dax_map_atomic()")
>     bda807d44454 ("mm: migrate: support non-lru movable page migration")
>     c8b8e32d700f ("direct-io: eliminate the offset argument to ->direct_IO")
>     d1a5f2b4d8a1 ("block: use DAX for partition table reads")
>     e10624f8c097 ("pmem: fail io-requests to known bad blocks")
> 
> v3.18.133: Failed to apply! Possible dependencies:
>     0722b1011a5f ("f2fs: set page private for inmemory pages for truncation")
>     1601839e9e5b ("f2fs: fix to release count of meta page in ->invalidatepage")
>     2916ecc0f9d4 ("mm/migrate: new migrate mode MIGRATE_SYNC_NO_COPY")
>     31a3268839c1 ("f2fs: cleanup if-statement of phase in gc_data_segment")
>     34ba94bac938 ("f2fs: do not make dirty any inmemory pages")
>     34d67debe02b ("f2fs: add infra struct and helper for inline dir")
>     4634d71ed190 ("f2fs: fix missing kmem_cache_free")
>     487261f39bcd ("f2fs: merge {invalidate,release}page for meta/node/data pages")
>     5b7a487cf32d ("f2fs: add customized migrate_page callback")
>     67298804f344 ("f2fs: introduce struct inode_management to wrap inner fields")
>     769ec6e5b7d4 ("f2fs: call radix_tree_preload before radix_tree_insert")
>     7dda2af83b2b ("f2fs: more fast lookup for gc_inode list")
>     8b26ef98da33 ("f2fs: use rw_semaphore for nat entry lock")
>     8c402946f074 ("f2fs: introduce the number of inode entries")
>     9be32d72becc ("f2fs: do retry operations with cond_resched")
>     9e4ded3f309e ("f2fs: activate f2fs_trace_pid")
>     d5053a34a9cc ("f2fs: introduce -o fastboot for reducing booting time only")
>     e5e7ea3c86e5 ("f2fs: control the memory footprint used by ino entries")
>     f68daeebba5a ("f2fs: keep PagePrivate during releasepage")
> 
> 
> How should we proceed with this patch?

Hello automated Sasha,

First, let's wait for review/ack.  However, the patch does not strictly
'depend' on the functionality of the commits in the lists above.  If/when
this goes upstream I can provide backports for 4.9, 4.4 and 3.18.

-- 
Mike Kravetz