[PATCH 3.16 211/305] exportfs: fix 'passing zero to ERR_PTR()' warning

From: Ben Hutchings
Date: Sun Feb 03 2019 - 08:56:40 EST

3.16.63-rc1 review patch. If anyone has any objections, please let me know.


From: YueHaibing <yuehaibing@xxxxxxxxxx>

commit 909e22e05353a783c526829427e9a8de122fba9c upstream.

Fix a static code checker warning:
fs/exportfs/expfs.c:171 reconnect_one() warn: passing zero to 'ERR_PTR'

The error path for lookup_one_len_unlocked failure
should set err to PTR_ERR.

Fixes: bbf7a8a3562f ("exportfs: move most of reconnect_path to helper function")
Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
fs/exportfs/expfs.c | 1 +
1 file changed, 1 insertion(+)

--- a/fs/exportfs/expfs.c
+++ b/fs/exportfs/expfs.c
@@ -148,6 +148,7 @@ static struct dentry *reconnect_one(stru
if (IS_ERR(tmp)) {
dprintk("%s: lookup failed: %d\n", __func__, PTR_ERR(tmp));
+ err = PTR_ERR(tmp);
goto out_err;
if (tmp != dentry) {