RE: [PATCH] libnvdimm/dimm: Add a no-BLK quirk based on NVDIMM family

From: Dexuan Cui
Date: Sun Feb 03 2019 - 12:39:20 EST


> From: kbuild test robot <lkp@xxxxxxxxx>
> Sent: Sunday, February 3, 2019 6:32 AM
> To: Dan Williams <dan.j.williams@xxxxxxxxx>
> Cc: kbuild-all@xxxxxx; linux-nvdimm@xxxxxxxxxxxx; Dexuan Cui
> <decui@xxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] libnvdimm/dimm: Add a no-BLK quirk based on NVDIMM
> family
>
> Hi Dan,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on linux-nvdimm/libnvdimm-for-next]
> [also build test ERROR on v5.0-rc4 next-20190201]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system]
> ...
> All errors (new ones prefixed by >>):
>
> drivers/acpi//nfit/core.c: In function 'acpi_nfit_register_dimms':
> >> drivers/acpi//nfit/core.c:2003:27: error: 'NVDIMM_FAMILY_HYPERV'
> undeclared (first use in this function); did you mean 'NVDIMM_FAMILY_HPE2'?
> if (nfit_mem->family == NVDIMM_FAMILY_HYPERV)
> ^~~~~~~~~~~~~~~~~~~~
> NVDIMM_FAMILY_HPE2
> drivers/acpi//nfit/core.c:2003:27: note: each undeclared identifier is
> reported only once for each function it appears in

This is a false alarm. The patch is only for
https://git.kernel.org/pub/scm/linux/kernel/git/djbw/nvdimm.git/log/?h=libnvdimm-pending
where we have the dependant commid
1194c4133195 ("nfit: Add Hyper-V NVDIMM DSM command set to white list")

Thanks,
-- Dexuan