Re: [PATCH] cpufreq: tegra124: add missing of_node_put()

[Frank Lee]

On Mon, Feb 4, 2019 at 3:18 PM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>
> On 04-02-19, 15:00, Frank Lee wrote:
> > On Mon, Feb 4, 2019 at 2:36 PM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> > >
> > > On 04-02-19, 01:35, Yangtao Li wrote:
> > > > of_cpu_device_node_get() will increase the refcount of device_node,
> > > > it is necessary to call of_node_put() at the end to release the
> > > > refcount.
> > > >
> > > > Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx>
> > > > ---
> > > >  drivers/cpufreq/tegra124-cpufreq.c | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/cpufreq/tegra124-cpufreq.c b/drivers/cpufreq/tegra124-cpufreq.c
> > > > index 43530254201a..140a9266b64a 100644
> > > > --- a/drivers/cpufreq/tegra124-cpufreq.c
> > > > +++ b/drivers/cpufreq/tegra124-cpufreq.c
> > > > @@ -118,6 +118,8 @@ static int tegra124_cpufreq_probe(struct platform_device *pdev)
> > > >               goto out_put_pllx_clk;
> > > >       }
> > > >
> > > > +     of_node_put(np);
> > > > +
> > > >       ret = tegra124_cpu_switch_to_dfll(priv);
> > > >       if (ret)
> > > >               goto out_put_pllp_clk;
> > >
> > > Fixes and stable tags ?
> > Hi viresh,
> >
> > Like thisï
> >
> > Fixes: 9eb15dbbfa1a2 ("cpufreq: Add cpufreq driver for Tegra124")
> > Cc: stable@xxxxxxxxxxxxxxx
>
> This needs to be something like:
>
> Cc: 4.5+ stable@xxxxxxxxxxxxxxx #4.5+
>
> Also I don't think your patch is entirely correct as we will end up
> doing of_node_put() twice in error path.
Thanks for your reminder, I will modify it immediately.

MBR,
Yangtao
>
> --
> viresh