Re: [PATCH v6 3/5] cgroup/cpuset: make callback_lock raw

From: Peter Zijlstra
Date: Mon Feb 04 2019 - 06:56:18 EST


On Thu, Jan 17, 2019 at 09:47:37AM +0100, Juri Lelli wrote:
> @@ -2366,7 +2366,7 @@ static int cpuset_common_seq_show(struct seq_file *sf, void *v)
> cpuset_filetype_t type = seq_cft(sf)->private;
> int ret = 0;
>
> - spin_lock_irq(&callback_lock);
> + raw_spin_lock_irq(&callback_lock);
>
> switch (type) {
> case FILE_CPULIST:
> @@ -2388,7 +2388,7 @@ static int cpuset_common_seq_show(struct seq_file *sf, void *v)
> ret = -EINVAL;
> }
>
> - spin_unlock_irq(&callback_lock);
> + raw_spin_unlock_irq(&callback_lock);
> return ret;
> }
>
could we not convert this to use cpuset_mutex ?