Re: [PATCH 06/10] x86/cpu: Add Icelake to Intel family

[Bhardwaj, Rajneesh]

On 04-Feb-19 11:04 PM, Thomas Gleixner wrote:
> On Fri, 1 Feb 2019, Rajneesh Bhardwaj wrote:
>
> > Add CPUID of Icelake (ICL) mobile processors to Intel family list. The
> > Information related to ICL CPUID is referenced from below Coreboot
> > project link.
> >
> > https://github.com/coreboot/coreboot/blob/5ebcea3aaaa3cd358bc5bccaa156b13a6ef25df6/src/soc/intel/common/block/include/intelblocks/mp_init.h
> Coreboot files are hardly authoritive information about CPUIDs.

It may take a while for it to be published in the SDMs.

> > diff --git a/arch/x86/include/asm/intel-family.h b/arch/x86/include/asm/intel-family.h
> > index 0dd6b0f4000e..12b65bdb3d80 100644
> > --- a/arch/x86/include/asm/intel-family.h
> > +++ b/arch/x86/include/asm/intel-family.h
> > @@ -52,6 +52,8 @@
> >   
> >   #define INTEL_FAM6_CANNONLAKE_MOBILE	0x66
> >   
> > +#define INTEL_FAM6_ICELAKE_MOBILE       0x7E
> Please use TABs instead of a random number of spaces.

Sure, I will fix this.

> Thanks,
>
> 	tglx