Re: [PATCH v3 0/2] Bluetooth: Add NULL check for tiocmget() and tiocmset()

From: Marcel Holtmann
Date: Tue Feb 05 2019 - 08:55:55 EST


Hi Myungho,

> tiocmget() and tiocmset() operations are optional and some tty drivers
> like pty miss the operations. Add NULL checks to prevent from
> dereference.
>
> Myungho Jung (2):
> Bluetooth: hci_ath: Add NULL check for tiocmget() and tiocmset() in
> ath_setup()
> Bluetooth: hci_ldisc: Add NULL check for tiocmget() and tiocmset() in
> hci_uart_set_flow_control()
>
> drivers/bluetooth/hci_ath.c | 6 ++++++
> drivers/bluetooth/hci_ldisc.c | 4 ++++
> 2 files changed, 10 insertions(+)

why are we not enforcing the availability of these in the hci_uart_tty_open?

Regards

Marcel