Re: [PATCH V4 0/6] add pvpanic driver framework
From: Andy Shevchenko
Date: Tue Feb 05 2019 - 10:31:17 EST
On Sun, Feb 3, 2019 at 11:23 AM <peng.hao2@xxxxxxxxxx> wrote:
> >> QEMU community requires additional PCI devices to simulate PVPANIC
> >> devices so that some architectures can not occupy precious less than 4G
> >> of memory space.
> >> Previously, I added PCI driver directly to the original version of the driver,
> >> which made the whole driver file look a bit cluttered. So Andy Shevchenko suggests:
> >> "I would recommend to split it in a way how it's done for ChipIdea USB driver,
> >> for example. (drivers/usb/chipidea if I'm not mistaken)".
> >Thank you for an update.
> >The series has the bisectability issues.
> >Try to use the following approach (if I got your idea right):
> >1. Convert to use common probe() etc functions inplace
> I think there is no "common probe" for acpi/OF/PCI .
In that case a careful split would be preferred.
> In this driver framework (like chipidea driver framework), acpi/OF/PCI
> driver's probe trigger the driver framework's probe. In the driver framework
> it create a new platform device as the acpi/OF/PCI device's child device.
> I don't understand how the bisectability issues happen.
IIRC you have a gap in between of couple of patches where in first
some functionality is removed and reappeared later on.
With Best Regards,