Re: [PATCH] perf vendor events intel: Fix Load_Miss_Real_Latency on CLX

[Arnaldo Carvalho de Melo]

Em Tue, Jan 29, 2019 at 09:23:48AM -0800, Andi Kleen escreveu:
> On Tue, Jan 29, 2019 at 12:05:36PM -0500, William Cohen wrote:
> > Fix incorrect event names for the Load_Miss_Real_Latency metric for
> > Cascadelake server in the same manner as commit 91b2b97025 for SKL/SKX.
> 
> Reviewed-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

Thanks, applied.

- Arnaldo
 
> > 
> > Signed-off-by: William Cohen <wcohen@xxxxxxxxxx>
> > ---
> >  tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
> > index 36c903faed0b..71e9737f4614 100644
> > --- a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
> > +++ b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
> > @@ -73,7 +73,7 @@
> >      },
> >      {
> >          "BriefDescription": "Actual Average Latency for L1 data-cache miss demand loads",
> > -        "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS_PS + MEM_LOAD_RETIRED.FB_HIT_PS )",
> > +        "MetricExpr": "L1D_PEND_MISS.PENDING / ( MEM_LOAD_RETIRED.L1_MISS + MEM_LOAD_RETIRED.FB_HIT )",
> >          "MetricGroup": "Memory_Bound;Memory_Lat",
> >          "MetricName": "Load_Miss_Real_Latency"
> >      },
> > -- 
> > 2.20.1
> > 

-- 

- Arnaldo