Re: [PATCH net-next v3 00/12] net: Introduce ndo_get_port_parent_id()

From: Ido Schimmel
Date: Wed Feb 06 2019 - 09:24:14 EST


On Wed, Feb 06, 2019 at 09:51:36AM +0200, Ido Schimmel wrote:
> On Tue, Feb 05, 2019 at 03:53:14PM -0800, Florian Fainelli wrote:
> > Hi all,
> >
> > Based on discussion with Ido and feedback from Jakub there are clearly
> > two classes of users that implement SWITCHDEV_ATTR_ID_PORT_PARENT_ID:
> >
> > - PF/VF drivers which typically only implement return the port's parent
> > ID, yet have to implement switchdev_port_attr_get() just for that
> >
> > - Ethernet switch drivers: mlxsw, ocelot, DSA, etc. which implement more
> > attributes which we want to be able to eventually veto in the context
> > of the caller, thus making them candidates for using a blocking notifier
> > chain
>
> Florian, patches look good to me. I'm going to build a kernel with these
> patches and run some tests. Will report later today.

Ran most of our tests and nothing exploded. Thanks!