Re: [v3 PATCH 1/8] RISC-V: Do not wait indefinitely in __cpu_up

From: Christoph Hellwig
Date: Fri Feb 08 2019 - 04:01:52 EST


On Thu, Feb 07, 2019 at 05:51:14PM -0800, Atish Patra wrote:
> In SMP path, __cpu_up waits for other CPU to come online
> indefinitely. This is wrong as other CPU might be disabled
> in machine mode and possible CPU is set to the cpus present
> in DT.
>
> Introduce a completion variable and waits only for a second.
>
> Signed-off-by: Atish Patra <atish.patra@xxxxxxx>
> Reviewed-by: Anup Patel <anup@xxxxxxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>