Re: [PATCH v2] mm: proc: smaps_rollup: Fix pss_locked calculation

From: Vlastimil Babka
Date: Fri Feb 08 2019 - 12:04:28 EST


On 2/3/19 7:54 AM, Sandeep Patil wrote:
> The 'pss_locked' field of smaps_rollup was being calculated incorrectly.
> It accumulated the current pss everytime a locked VMA was found. Fix
> that by adding to 'pss_locked' the same time as that of 'pss' if the vma
> being walked is locked.
>
> Fixes: 493b0e9d945f ("mm: add /proc/pid/smaps_rollup")
> Cc: stable@xxxxxxxxxxxxxxx # 4.14.y 4.19.y
> Signed-off-by: Sandeep Patil <sspatil@xxxxxxxxxxx>

Acked-by: Vlastimil Babka <vbabka@xxxxxxx>

Thanks.

> ---
>
> v1->v2
> ------
> - Move pss_locked accounting into smaps_account() inline with pss