Re: [PATCH v3 00/15] Habana Labs kernel driver

[Oded Gabbay]

On Fri, Feb 8, 2019 at 11:43 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Fri, 2019-02-08 at 23:33 +0200, Oded Gabbay wrote:
> > On Wed, Feb 6, 2019 at 1:52 PM Mike Rapoport <rppt@xxxxxxxxxxxxx> wrote:
> > > On Mon, Feb 04, 2019 at 10:32:39PM +0200, Oded Gabbay wrote:
> > > > Hello,
> > > > This is v3 of the Habana Labs kernel driver patch-set. It contains minor fixes
> > > > according to reviews done on v2. In addition, it is rebased on v5.0-rc5.
> []
> > > Nit: git am is unhappy about black lines at EOF, e.g:
> > >
> > > Applying: habanalabs: add basic Goya support
> > > .git/rebase-apply/patch:29: new blank line at EOF.
> > > +
> > Yes, but on the other hand, joe perches gave me a comment about
> > missing newline at end of Makefile.
> > So either diff will complain or git am.
>
> Not really.
>
> The desired modification was the last non-blank line of
> the Makefile should have a terminating newline, not that
> there was a blank line at EOF.
>
>
ok, thanks for the clarification, I'll fix that.
Oded